Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reauth source constant for config entries #40352

Merged
merged 2 commits into from Sep 21, 2020
Merged

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Sep 20, 2020

Breaking change

Proposed change

Frontend already uses this "magic" string to display warning to user and multiple integrations implement reauth with this source.

ref home-assistant/frontend#6808

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added code-quality core small-pr PRs with less than 30 lines. labels Sep 20, 2020
@project-bot project-bot bot added this to Needs review in Dev Sep 20, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok for now until we've fleshed out how this should work in the future.

Dev automation moved this from Needs review to Reviewer approved Sep 20, 2020
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend already supports it, seems fine to me

@bdraco bdraco merged commit 37e51aa into dev Sep 21, 2020
Dev automation moved this from Reviewer approved to Done Sep 21, 2020
@bdraco bdraco deleted the ctalkington-patch-reauth branch September 21, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants