Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in Nextcloud component #40438

Merged
merged 1 commit into from Sep 22, 2020
Merged

Fix regression in Nextcloud component #40438

merged 1 commit into from Sep 22, 2020

Conversation

meichthys
Copy link
Contributor

Proposed change

This fixes #40372
A regression was introduced in the fix for #40122 which seems to have broke the component for most users.
The sooner we can get this merged the better!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

@project-bot project-bot bot added this to Needs review in Dev Sep 22, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Sep 22, 2020
@meichthys meichthys changed the title Nextcloud Fix regression in Nextcloud component Sep 22, 2020
@meichthys
Copy link
Contributor Author

@MartinHjelmare
Is this ok? I'm lost on how to rebase.

@MartinHjelmare MartinHjelmare self-assigned this Sep 22, 2020
@MartinHjelmare
Copy link
Member

I rebased the branch on latest dev.

@MartinHjelmare MartinHjelmare removed their assignment Sep 22, 2020
Dev automation moved this from By Code Owner to Reviewer approved Sep 22, 2020
MartinHjelmare
MartinHjelmare approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 0.115.3 milestone Sep 22, 2020
@springstan springstan merged commit 2f9afd3 into home-assistant:dev Sep 22, 2020
Dev automation moved this from Reviewer approved to Done Sep 22, 2020
@meichthys
Copy link
Contributor Author

Thanks!

frenck pushed a commit that referenced this pull request Sep 25, 2020
@meichthys @frenck
Fix regression in Nextcloud component (#40438)
95e6969
This was referenced Sep 25, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: nextcloud small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
0.115.3
Development

Successfully merging this pull request may close these issues.

Error when setting up Nextcloud integration on 0.115.2
5 participants
@meichthys @MartinHjelmare @springstan @frenck @homeassistant