Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OZW node config parameters websocket commands #40527

Merged
merged 39 commits into from
Oct 5, 2020
Merged

Add OZW node config parameters websocket commands #40527

merged 39 commits into from
Oct 5, 2020

Commits on Sep 24, 2020

  1. add websocket commands to retrieve and set config parameters for a node

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d6434d1 View commit details
    Browse the repository at this point in the history

  2. move set_config_parameter into generic function and refactor service … 

    …and WS API
    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7f01e98 View commit details
    Browse the repository at this point in the history

  3. add payload to return to make service call behave the same way it did… 

    … before
    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    fc00b50 View commit details
    Browse the repository at this point in the history

  4. create response class

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    dbed308 View commit details
    Browse the repository at this point in the history

  5. update error message to pass tests

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    859ad4e View commit details
    Browse the repository at this point in the history

  6. move things a bit to reduce LOC

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    1aa7828 View commit details
    Browse the repository at this point in the history

  7. add tests

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    c8e4d31 View commit details
    Browse the repository at this point in the history

  8. handle logging errors better and make new response class more generic… 

    … to prepare for lock user code work
    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    fceba61 View commit details
    Browse the repository at this point in the history

  9. remove unused function parameter

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    76a96b8 View commit details
    Browse the repository at this point in the history

  10. invert check

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    43412c2 View commit details
    Browse the repository at this point in the history

  11. add additional error checking

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    1b538cd View commit details
    Browse the repository at this point in the history

  12. refactor a bit to remove repeat code

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    746d6d4 View commit details
    Browse the repository at this point in the history

  13. revert log msg change

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    9d9ae2f View commit details
    Browse the repository at this point in the history

  14. one more refactor to create generic get_config_parameters function

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    58b02ae View commit details
    Browse the repository at this point in the history

  15. change if logic for consistency

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    4035bf8 View commit details
    Browse the repository at this point in the history

  16. fix test

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    0d2a225 View commit details
    Browse the repository at this point in the history

  17. add support to provide bool value in set_config_parameter service call

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    97ab42d View commit details
    Browse the repository at this point in the history

  18. standardize parameter names on service call

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    9638b08 View commit details
    Browse the repository at this point in the history

  19. add test coverage

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    388736e View commit details
    Browse the repository at this point in the history

  20. fix tests and message sending

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    d16ab68 View commit details
    Browse the repository at this point in the history

  21. remove unnecessary logging import

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    4f96442 View commit details
    Browse the repository at this point in the history

  22. fix one test to get missing coverage

    @raman325
    raman325 committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    a3937fc View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. update per martin and kpines reviews

    @raman325
    raman325 committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    0c2e216 View commit details
    Browse the repository at this point in the history

  2. remove false assertion

    @raman325
    raman325 committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    b9ab92d View commit details
    Browse the repository at this point in the history

  3. string line length

    @raman325
    raman325 committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    24934a7 View commit details
    Browse the repository at this point in the history

  4. add support for Decimal config param, remove node instance ID as inpu… 

    …t, and move helper functions to node.py
    @raman325
    raman325 committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    e811927 View commit details
    Browse the repository at this point in the history

  5. cast Decimal appropriately

    @raman325
    raman325 committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    36a7a43 View commit details
    Browse the repository at this point in the history

  6. revert change to support Decimal for config params since they are not… 

    … supported as a config param type
    @raman325
    raman325 committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    cd13694 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. revert to using error arguments to make next PR for WS lock commands … 

    …easier
    @raman325
    raman325 committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    2fbdfbe View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. switch to class method and add guard for list Value not being a number

    @raman325
    raman325 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    3fdbc31 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. update logic to use new openzwavemqtt util methods

    @raman325
    raman325 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    a2b87c7 View commit details
    Browse the repository at this point in the history

  2. add support for bitsets

    @raman325
    raman325 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    43e444b View commit details
    Browse the repository at this point in the history

  3. use parent exception class

    @raman325
    raman325 committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    559d044 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. bump openzwavemqtt version, remove node.py from .coveragerc and put f… 

    …ile references in the right place
    @raman325
    raman325 committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    48aba1a View commit details
    Browse the repository at this point in the history

  2. add comment

    @raman325
    raman325 committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    8ea19d7 View commit details
    Browse the repository at this point in the history

  3. improve config validation

    @raman325
    raman325 committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    7ee8372 View commit details
    Browse the repository at this point in the history

  4. remove bitset support from config validation

    @raman325
    raman325 committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    2f5bf5f View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. re-add bitset support with some additional tests

    @raman325
    raman325 committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    a89e6a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. move send_result out of try block

    @raman325
    raman325 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    3278138 View commit details
    Browse the repository at this point in the history