Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable hdmi_cec component #40671

Merged
merged 1 commit into from Sep 28, 2020
Merged

Re-enable hdmi_cec component #40671

merged 1 commit into from Sep 28, 2020

Conversation

newAM
Copy link
Contributor

@newAM newAM commented Sep 27, 2020

Proposed change

This change re-enables the hdmi_cec component.
The component was removed in #37707 because it had a dependency on typing, which has since been resolved with the latest release of pyCEC, 0.4.14.

konikvranik/pyCEC@v0.4.13...v0.4.14

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @newAM,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Contributor

@KevinCathcart KevinCathcart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you intend to help work on this integration going forward (since you are now a maintainer of the upstream library), please add yourself to the codeowners in manifest.json too. (Then run python3 -m script.hassfest to update the top level CODEOWNERS file).

Otherwise, this looks good, of course.

@newAM
Copy link
Contributor Author

newAM commented Sep 27, 2020

If you intend to help work on this integration going forward (since you are now a maintainer of the upstream library)

I am not sure if this is a long-term position, I only have PyPi access to the upstream right now (no repository access), I am clarifying with the owner of pyCEC.
I am happy to put my name down if my maintainer status of pyCEC becomes an ongoing role 馃憤

@newAM
Copy link
Contributor Author

newAM commented Sep 27, 2020

I have repository access now, I added myself as a codeowner.

P.S. Sorry if rebasing changes is discouraged, I did not find anything in the developer workflow about it. I know some places dislike them, and others require them.

@MartinHjelmare
Copy link
Member

Please add a link to the changelog or github commit compare range for the version bump in the PR description.

@MartinHjelmare MartinHjelmare changed the title Re-enable hdmi_cec component. Re-enable hdmi_cec component Sep 27, 2020
@newAM
Copy link
Contributor Author

newAM commented Sep 27, 2020

Please add a link to the changelog or github commit compare range for the version bump in the PR description.

Done! It is just two small commits between 0.4.13 and 0.4.14.

Commits in 0.4.14 since 0.4.13:

@MartinHjelmare
Copy link
Member

That's not really accurate. I've added the commit compare range to the description.

Dev automation moved this from Needs review to Reviewer approved Sep 28, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 373a1ca into home-assistant:dev Sep 28, 2020
Dev automation moved this from Reviewer approved to Done Sep 28, 2020
@newAM
Copy link
Contributor Author

newAM commented Sep 28, 2020

That's not really accurate. I've added the commit compare range to the description.

Things got a bit out of order :/. I made the release on a branch before I realized that I did not have permissions to merge it back into maater. The branches then got merged (rebased?) out of order. I added the tags retroactively to preserve as much history as possible, but it is what it is.

For the future I added a changelog and have some repository access, so there will be improved accounting of changes.

@TheDK
Copy link

TheDK commented Sep 29, 2020

Thanks newAM for driving this! I guess it will be in 0.116 next week or so?

@newAM
Copy link
Contributor Author

newAM commented Sep 29, 2020

This is my first contribution to home assistant so I know as much as you do :)

It seems like releases are currently on a 3 week cycle[1] so probably next week or the week after? There will be a beta before then though.

@KevinCathcart
Copy link
Contributor

KevinCathcart commented Sep 29, 2020 via email

Bre77 pushed a commit to Bre77/core that referenced this pull request Sep 30, 2020
Bre77 pushed a commit to Bre77/core that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants