New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use references in forked_daapd strings.json #40989
Use references in forked_daapd strings.json #40989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Can also change unknown_error
and already_configured
to
"unknown_error": "[%key:common::config_flow::error::unknown%]"
and
"already_configured": "[%key:common::config_flow::abort::already_configured_device%]",
b3aaa58
to
795cf16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -17,10 +17,10 @@ | |||
"wrong_host_or_port": "Unable to connect. Please check host and port.", | |||
"wrong_password": "Incorrect password.", | |||
"wrong_server_type": "The forked-daapd integration requires a forked-daapd server with version >= 27.0.", | |||
"unknown_error": "Unknown error." | |||
"unknown_error": "[%key:common::config_flow::error::unknown%]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The common key is just called unknown
. Please replace that too.
Proposed change
Use references in forked_daapd strings.json
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: