Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support matching multiple user ids in event trigger #41036

Merged
merged 3 commits into from Oct 8, 2020

Conversation

OnFreund
Copy link
Contributor

@OnFreund OnFreund commented Oct 2, 2020

Proposed change

As a followup to #40932, this allows multiple user ids to be used as a filter in event triggers.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
trigger:
  - platform: event
    event_type: test_event_context
    event_data:
    context:
      user_id:
        - my-user-id
        - another-user-id

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (homeassistant) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@OnFreund OnFreund requested a review from balloob October 2, 2020 12:52
@OnFreund
Copy link
Contributor Author

OnFreund commented Oct 8, 2020

@balloob anything else that's missing here? We merged the previous PR before deciding to change the semantics, so I want to make sure this one is merged quickly to avoid dev being in a temp state for too long.

Dev automation moved this from Needs review to Reviewer approved Oct 8, 2020
@balloob balloob merged commit b5e57ed into home-assistant:dev Oct 8, 2020
Dev automation moved this from Reviewer approved to Done Oct 8, 2020
@OnFreund OnFreund deleted the event_trigger_context branch October 8, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants