Use common strings for Harmony config flow #41094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
code-quality
integration: harmony
small-pr
groot406
changed the title
|
Hey there @ehendrix23, @bramkragten, @bdraco, mind taking a look at this pull request as its been labeled with an integration ( |
groot406
changed the title
Spartan-II-117
approved these changes
Oct 2, 2020
springstan
requested changes
Oct 2, 2020
Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>
| @@ -19,7 +19,7 @@ | |||
| "unknown": "[%key:common::config_flow::error::unknown%]" | |||
| }, | |||
| "abort": { | |||
| "already_configured": "[%key:common::config_flow::abort::already_configured_device%]" | |||
| "already_configured_device": "[%key:common::config_flow::abort::already_configured_device%]" | |||
There was a problem hiding this comment.
This should be reverted. The key needs to be already_configured to map to our helper method that aborts the flow if an existing entry has the same unique id.
This is an exception where the key can't match the the common string key.
21 tasks
ronanmu
pushed a commit
to ronanmu/home-assistant
that referenced
this pull request
Oct 3, 2020
* Use common strings for harmony component * Update homeassistant/components/harmony/strings.json Co-authored-by: springstan <46536646+springstan@users.noreply.github.com> * use default key for common config flow strings Co-authored-by: springstan <46536646+springstan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use of reference strings in Harmony config flow. See #40578
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: