Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyhomematic to 0.1.70 #41108

Merged
merged 1 commit into from Oct 3, 2020
Merged

Update pyhomematic to 0.1.70 #41108

merged 1 commit into from Oct 3, 2020

Conversation

danielperna84
Copy link
Contributor

@danielperna84 danielperna84 commented Oct 2, 2020

Proposed change

Update pyhomematic. The package was including the tests at the top level. This new version fixes this. Not sure how relevant this is for Home Assistant, but I assume it could cause a conflict in some cases.

https://github.com/danielperna84/pyhomematic/releases/tag/0.1.70

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Oct 2, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 2, 2020
@probot-home-assistant
Copy link

Hey there @pvizeli, mind taking a look at this pull request as its been labeled with an integration (homematic) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@springstan
Copy link
Member

Please add a link to the changelog or github commit compare range for the version bump in the PR description.

Dev automation moved this from By Code Owner to Reviewer approved Oct 3, 2020
@fabaff fabaff merged commit 8e4b10f into dev Oct 3, 2020
Dev automation moved this from Reviewer approved to Done Oct 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the homematic branch October 3, 2020 12:15
@frenck
Copy link
Member

frenck commented Oct 3, 2020

@fabaff This PR should not have been merged, @springstan requested additional information, which should be added to the PR.

@MartinHjelmare
Copy link
Member

I've pasted a link to the release tag in the PR description.

@danielperna84
Copy link
Contributor Author

For reference: this is all that changed from 0.1.69 (merged here on october 1st) to 0.1.70: https://github.com/danielperna84/pyhomematic/pull/335/files
So it's really just re-packaging of 0.1.69 without the tests that were at the wrong place. No changes in functionality.

ronanmu pushed a commit to ronanmu/home-assistant that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants