Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common strings for Panasonic Viera #41268

Merged
merged 12 commits into from Oct 6, 2020
Merged

Use common strings for Panasonic Viera #41268

merged 12 commits into from Oct 6, 2020

Conversation

TopdRob
Copy link
Contributor

@TopdRob TopdRob commented Oct 5, 2020

Breaking change

Proposed change

Use common strings for Panasonic Viera #40578

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Oct 5, 2020
@probot-home-assistant
Copy link

Hey there @joogps, mind taking a look at this pull request as its been labeled with an integration (panasonic_viera) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@TopdRob TopdRob changed the title Use common strings for Panasonic Vierra Use common strings for Panasonic Viera Oct 5, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the config flow and test for the renamed keys.

homeassistant/components/panasonic_viera/strings.json Outdated Show resolved Hide resolved
homeassistant/components/panasonic_viera/strings.json Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Oct 5, 2020
TopdRob and others added 3 commits October 5, 2020 16:43
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@TopdRob
Copy link
Contributor Author

TopdRob commented Oct 5, 2020

This component does not seems to use pytest yet.

@MartinHjelmare
Copy link
Member

@TopdRob
Copy link
Contributor Author

TopdRob commented Oct 5, 2020

Here's the test module:
https://github.com/home-assistant/core/blob/dev/tests/components/panasonic_viera/test_config_flow.py

Thanks, this is all quite new to me. I will have a look.

Dev automation moved this from Review in progress to Reviewer approved Oct 5, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TopdRob
Copy link
Contributor Author

TopdRob commented Oct 5, 2020

I'm sorry I don't know how to fix this anymore.

Dev automation moved this from Reviewer approved to Review in progress Oct 5, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should pass now. Thanks!

Dev automation moved this from Review in progress to Reviewer approved Oct 5, 2020
@davet2001 davet2001 mentioned this pull request Oct 6, 2020
21 tasks
@MartinHjelmare
Copy link
Member

Coverage isn't affected by this change. Merging.

@MartinHjelmare MartinHjelmare merged commit 888c92a into home-assistant:dev Oct 6, 2020
Dev automation moved this from Reviewer approved to Done Oct 6, 2020
@TopdRob TopdRob deleted the patch-1 branch October 6, 2020 13:01
@joogps joogps mentioned this pull request Oct 7, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants