Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent "percent" naming in systemmonitor #41411

Merged
merged 1 commit into from Oct 11, 2020

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Follow-up to PR #36283, specifically this request from @MartinHjelmare #36283 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@spacegaier
Copy link
Member Author

@MartinHjelmare I also considered removing the "(percent)" for all sensors, since it is clear from the "%" in the value. However, since the entity_id is derived from the name, the IDs would would look bad (sensor.disk_use_home and sensor.disk_use_home_2 instead of sensor.disk_use_home and sensor.disk_use_percent_home as they are today). When I tried setting the entity_id directly in the integration, it failed and I think that is anyway not the way to go, correct?

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good! Thanks!

Dev automation moved this from Needs review to Reviewer approved Oct 7, 2020
@MartinHjelmare MartinHjelmare changed the title Use consistent "percent" naming Use consistent "percent" naming in systemmonitor Oct 7, 2020
@springstan springstan merged commit b6a9372 into home-assistant:dev Oct 11, 2020
Dev automation moved this from Reviewer approved to Done Oct 11, 2020
@spacegaier spacegaier deleted the systemmonitor branch October 11, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants