New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump yeelight to 0.5.4 #41524
Bump yeelight to 0.5.4 #41524
Conversation
Hey there @rytilahti, @zewelor, mind taking a look at this pull request as its been labeled with an integration ( |
It looks like its this commit https://gitlab.com/stavros/python-yeelight/-/commit/78632f8e8f652df67010524fb4bbd7ea6990da85 |
Its definitely now It seems the CI is using an old package? |
Maybe we should also change file requirements_all.txt to bump the version to 0.5.4 ? I think that there is problem with 0.5.3 — #41507 (comment) |
After thinking about this problem a bit I think that we definitely should change the version in requirements_all.txt to 0.5.4 I'm not sure what the author of yeelight will do. If he re-re-upload 0.5.3 with the same code as before Home Assistant yeelight integration will break again. |
I also think we should bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this change locally and everything works as it should.
IMO, this PR should be tagged |
Most of problems are fixed in 0.116.2, but something is still broken. |
Please open an issue. Thanks! |
Proposed change
The bug is introduced in #39542.yeelight
version 0.5.3 renamestransitions.randomloop
totransitions.random_loop
which causes AttributeError.The author of the
yeelight
library uploads multiple files of version 0.5.3 with different code that causesAttributeError
. Bumpyeelight
to 0.5.4 to fix this problem.Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: