Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HomeKit to be configured in include mode from the UI #41662

Merged
merged 1 commit into from Oct 15, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 11, 2020

Proposed change

Allow HomeKit to be configured in include mode from the UI

Part 1 of solving #40245 and #39903

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Oct 11, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 11, 2020
@bdraco bdraco force-pushed the homekit_include_mode branch 2 times, most recently from cbbbd7c to 5d5f99c Compare October 11, 2020 15:31
@bdraco bdraco marked this pull request as ready for review October 11, 2020 15:37
data_schema = vol.Schema(
{
vol.Required(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing all this, I wonder if we should add a new type "specify entity include/excludes" and have it render in the frontend with a native widget. We already define cv.custom_serializer and could add support for the entity filter schema on the backend.

@bramkragten what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an idea for a future PR btw, it shouldn't block this.

Dev automation moved this from By Code Owner to Reviewer approved Oct 15, 2020
@balloob balloob merged commit c5ae801 into home-assistant:dev Oct 15, 2020
Dev automation moved this from Reviewer approved to Done Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants