Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch legacy async_add_job to async_add_executor_job in wemo #41807

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2020

Proposed change

Switch legacy async_add_job to async_add_executor_job in wemo

These calls were already using async_add_executor_job in some of the
other platforms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

These calls were already using async_add_executor_job in some of the
other platforms
@probot-home-assistant probot-home-assistant bot added integration: wemo small-pr PRs with less than 30 lines. labels Oct 13, 2020
@project-bot project-bot bot added this to Needs review in Dev Oct 13, 2020
Dev automation moved this from Needs review to Reviewer approved Oct 14, 2020
@MartinHjelmare MartinHjelmare merged commit 6c0d5fa into home-assistant:dev Oct 14, 2020
Dev automation moved this from Reviewer approved to Done Oct 14, 2020
weissm pushed a commit to weissm/core that referenced this pull request Oct 16, 2020
…ssistant#41807)

These calls were already using async_add_executor_job in some of the
other platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants