Use common strings in opentherm_gw config flow #42211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
bugfix
integration: opentherm_gw
small-pr
mvn23
reviewed
Oct 22, 2020
Comment on lines
16
to
17
| "serial_error": "[%key:common::config_flow::error::cannot_connect%]", | ||
| "timeout": "[%key:common::config_flow::error::cannot_connect%]" |
There was a problem hiding this comment.
If we're going to use the same error for both cases, we may as well merge them into one cannot_connect error condition in the config flow.
There was a problem hiding this comment.
True. Originally I did not want to touch the code, but I'll add a commit to reduce it to a single check.
There was a problem hiding this comment.
Ok, commited that.
There was a problem hiding this comment.
And I shouldn't have commited without running the tests again, so another commit to fix the test.
mvn23
reviewed
Oct 23, 2020
|
Ok, changed the name of the error key. |
mvn23
approved these changes
Oct 25, 2020
rajlaud
pushed a commit
to rajlaud/home-assistant
that referenced
this pull request
Oct 28, 2020
* Use common strings in opentherm_gw config flow * Combine TimeourError and SerialException handling * Fixed test_form_connection_error * And then fix the flake8 error... * Change "timeout" to "cannot_connect" msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Contribute to issue #40578
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
I did not convert strings
deviceorid_existsto common strings because there are no common strings that fully cover the intended message.For
deviceit is uncommon that either a path (/dev/ttyS1) or an URL can be entered.For
id_exists, the error message describes that the given ID is the issue and not the combinatie of ID and device.Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: