Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert somfy to use DataUpdateCoordinator #42434

Merged
merged 1 commit into from Oct 27, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 26, 2020

Proposed change

Convert somfy to use DataUpdateCoordinator

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @tetienne, mind taking a look at this pull request as its been labeled with an integration (somfy) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco force-pushed the somfy_duc branch 2 times, most recently from 2ac6113 to 15c621d Compare October 26, 2020 21:35
@bdraco
Copy link
Member Author

bdraco commented Oct 26, 2020

I have a lot of RTS devices so no more jumps into the executor only to hit the throttle since the coordinator takes care of the updates.

I read the profile wrong. It wasn't this one that was causing all the executor jobs. Well one more integration converted 馃憤

Dev automation moved this from Needs review to Reviewer approved Oct 27, 2020
@ctalkington ctalkington merged commit df25fea into home-assistant:dev Oct 27, 2020
Dev automation moved this from Reviewer approved to Done Oct 27, 2020
@tetienne
Copy link
Contributor

For later, it would be nice to increase the poll interval (to the refresh token date) when all the devices are in assumed state.

@bdraco
Copy link
Member Author

bdraco commented Oct 27, 2020

For later, it would be nice to increase the poll interval (to the refresh token date) when all the devices are in assumed state.

Will do in the follow up.

We can probably poll hourly?? in this case.

@tetienne
Copy link
Contributor

If it鈥檚 less than the refresh token interval, yes.

@bdraco bdraco mentioned this pull request Oct 27, 2020
21 tasks
@bdraco
Copy link
Member Author

bdraco commented Oct 27, 2020

For later, it would be nice to increase the poll interval (to the refresh token date) when all the devices are in assumed state.

Will do in the follow up.

We can probably poll hourly?? in this case.

done here #42462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants