Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force color or white mode exclusivity for MQTT lights #42887

Merged
merged 1 commit into from Nov 9, 2020

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Nov 5, 2020

Breaking change

Home Assistant internally assumes that a light either has a color or a color temperature.
MQTT lights, basic schema, with support for both color and color temperature will report a color if white_value is 0 or None and a color_temp is white_value > 0.

By enforcing this, setting scenes for MQTT lights with basic schema supporting both color temperature and color will now work.

Starting with HA 0.118, an

Proposed change

Force color or white mode exclusivity for MQTT lights using basic schema to prevent ambiguous states which can't be restored.
This affects RGBW and RGBWW lights.

Implemented by interpreting white_value as a selector between color mode or white mode:

  • white_value undefined or 0

    • light is in color mode
    • white_value and color_temperature will not be included in state
    • hs_color will be included in state
  • white_value > 0

    • light is in white mode
    • white_value and color_temperature will be included in state
    • hs_color will not be included in state

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (mqtt) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 5, 2020
Dev automation moved this from By Code Owner to Reviewer approved Nov 9, 2020
@balloob balloob merged commit b45fa29 into home-assistant:dev Nov 9, 2020
Dev automation moved this from Reviewer approved to Done Nov 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants