Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reboot_gateway service to Velux #43198

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Add reboot_gateway service to Velux #43198

merged 3 commits into from
Jan 29, 2021

Conversation

pawlizio
Copy link
Contributor

@pawlizio pawlizio commented Nov 13, 2020

Proposed change

Provides a workaround for #34844 by adding a reboot service for the KLF200 gateway which can be integrated in automations. Most likely:

alias: KLF reboot on hass stop event
description: ''
trigger:
  - event_data: {}
    event_type: homeassistant_stop
    platform: event
condition: []
action:
  - data: {}
    service: velux.reboot_gateway
mode: single

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Nov 13, 2020
@probot-home-assistant
Copy link

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with an integration (velux) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@springstan springstan changed the title Velux reboot_gateway service added Add reboot_gateway service to Velux Nov 13, 2020
@Julius2342
Copy link
Contributor

Julius2342 commented Nov 13, 2020

Yes, this is a useful improvement to work around KLF200 difficulties.

And it looks sane. (Im not much into the hass codebase at the moment).

Copy link
Contributor

@mtdcr mtdcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposes a newly added feature of pyvlx as a service. Useful, because the KLF200 has a tendency to stop accepting new connections after some time.

This was split out of #42773 to reduce complexity.

@mtdcr mtdcr mentioned this pull request Nov 24, 2020
21 tasks
@Julius2342
Copy link
Contributor

Hi home-assistant team, is there anything which blocks merging this PR?

@github-actions

This comment has been minimized.

@github-actions github-actions bot added the stale label Jan 26, 2021
@frenck
Copy link
Member

frenck commented Jan 26, 2021

Not stale, awaiting our review.

Dev automation moved this from Needs review to Review in progress Jan 26, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is fine ✅

However, it needs a documentation update to list this service. Please open a PR on our documentation and link it with this PR.

@pawlizio
Copy link
Contributor Author

@frenck I created a PR for documentation: https://github.com/home-assistant/home-assistant.io/pull/16352

Dev automation moved this from Review in progress to Reviewer approved Jan 29, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pawlizio 👍

@frenck frenck merged commit 48e899c into home-assistant:dev Jan 29, 2021
Dev automation moved this from Reviewer approved to Done Jan 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants