Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate check on onewire config flow #43590

Merged
merged 2 commits into from Nov 24, 2020

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Nov 24, 2020

Proposed change

Fix duplicate check on YAML import into config_flow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: onewire
    host: localhost
    names:
      28.000000010000: Temp Sensor 1
      28.000000020000: Temp Sensor 2
      28.000000030000: Temp Sensor 3

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @garbled1, mind taking a look at this pull request as its been labeled with an integration (onewire) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 24, 2020
@epenet epenet changed the title Patch onewire import Fix duplicate check on YAML import in onewire integration Nov 24, 2020
@epenet epenet changed the title Fix duplicate check on YAML import in onewire integration Fix duplicate check on onewire YAML import Nov 24, 2020
@epenet epenet changed the title Fix duplicate check on onewire YAML import Fix duplicate check on onewire config flow Nov 24, 2020
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Dev automation moved this from By Code Owner to Reviewer approved Nov 24, 2020
Copy link
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgarwood cgarwood added this to the 0.118.4 milestone Nov 24, 2020
@frenck frenck merged commit 48d9f1a into home-assistant:dev Nov 24, 2020
Dev automation moved this from Reviewer approved to Done Nov 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2020
@epenet epenet deleted the patch-onewire-import branch November 30, 2020 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Restarting Home Assistant leads to increasing number of onewire integration instances
6 participants