Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openwebifpy version: 3.1.1 → 3.1.6 #44064

Merged
merged 3 commits into from Dec 9, 2020
Merged

Conversation

fbradyirl
Copy link
Contributor

@fbradyirl fbradyirl commented Dec 8, 2020

Proposed change

Update openwebifpy version: 3.1.1 → 3.1.6

Fixes

All changes: fbradyirl/openwebifpy@v3.1.1...v3.1.6

Type of change

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Dec 8, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 8, 2020
Copy link
Contributor

@geoffreylagaisse geoffreylagaisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the version within the unittests be bumped too?

Dev automation moved this from By Code Owner to Review in progress Dec 8, 2020
and bump to 3.1.6
@fbradyirl fbradyirl changed the title Bump openwebifpy version: 3.1.1 → 3.1.3 Bump openwebifpy version: 3.1.1 → 3.1.6 Dec 9, 2020
@fbradyirl
Copy link
Contributor Author

can the version within the unittests be bumped too?

This component is not in unit tests.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Dev automation moved this from Review in progress to Reviewer approved Dec 9, 2020
@frenck frenck merged commit 12903f9 into home-assistant:dev Dec 9, 2020
Dev automation moved this from Reviewer approved to Done Dec 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Requirement is pinned for openwrt-luci-rpc 1.1.3: requests==2.21.0
4 participants