Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated CONF_ALLOW_UNLOCK, CONF_API_KEY from Google Assistant #44087

Merged
merged 3 commits into from Dec 10, 2020
Merged

Remove deprecated CONF_ALLOW_UNLOCK, CONF_API_KEY from Google Assistant #44087

merged 3 commits into from Dec 10, 2020

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Dec 9, 2020

Breaking change

Proposed change

Remove CONF_ALLOW_UNLOCK and CONF_API_KEY related code from google_assistant as the use of allow_unlock has been deprecated since version 0.95, and the use of api_key was deprecated in 0.105.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with an integration (google_assistant) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@hmmbob
Copy link
Contributor Author

hmmbob commented Dec 10, 2020

By the way, that makes this no longer a breaking change, correct?

@elupus elupus merged commit 9cc406f into home-assistant:dev Dec 10, 2020
@hmmbob hmmbob deleted the remove_deprecatated_ga branch December 10, 2020 20:51
@frenck
Copy link
Member

frenck commented Dec 10, 2020

馃帀

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
@frenck frenck added this to the 1.0.0 milestone Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants