Bump vlc_telnet to 2.0.1, several bug fixes

[dmcc]

Switch to python-telnet-vlc 2.0.1 and avoid some unnecessary int/str
conversions.

Add SUPPORT_VOLUME_STEP.

Fix various state issues (initial state not sent as part of first
update, unmute detection, seeking didn't actually work).

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[homeassistant]

Hi @dmcc,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[probot-home-assistant]

Hey there @rodripf, mind taking a look at this pull request as its been labeled with an integration (vlc_telnet) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[MartinHjelmare]

Please split this PR into at least three PRs:

• Bump library version
• Fix issues
• Add volume step support

[ludeeus]

Please split this PR into at least three PRs:

• Bump library version
• Fix issues
• Add volume step support

Marking this as "Request changes"

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[dmcc]

Sorry for the delay, finally had cycles to test what happens if we slice it up as requested. Unfortunately, while python-telnet-vlc is a general improvement, Home Assistant relies on bad its APIs. So, if we just bump the python-telnet-vlc version, we'll actually introduce two new issues (volume control will break and we'll no longer get any position status info).

Which course of action would you like to pursue?

1. Split into 3+ PRs as requested (this is presumably fine as long as they're not split across Home Assistant releases)
2. Split into 2 PRs: (1) bump python-telnet-vlc version and address breaking changes + fix bugs (mute/unmute detection, fix initial state update), (2) add SUPPORT_VOLUME_STEP
3. Split into 3 PRs: (1) bump python-telnet-vlc version and address breaking changes, (2) separate bugfixes (mute/unmute detection, fix initial state update), (3) add SUPPORT_VOLUME_STEP
4. Keep this as one larger PR
5. (something else?)

[MartinHjelmare]

Please do 3.

[dmcc]

Alright, I've extracted the first of several PRs into #46608 (apologies if there's a better way to do this in git).

(I'm planning to cancel this PR once the other PRs are in)

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[frenck]

Seems like 3 PR are made and merged. As far as I can see, the update handling changes have not ended up in the other PRs.

Is there still a PR on route? Or are you planning on rebasing/updating this PR?

[dmcc]

Hey @frenck, thanks for checking in. Right, update handling changes still haven't been pulled out and I'm still planning on getting to this (there might be others too). That said, there's probably no point in keeping this one open since it's not going anywhere, so will close it.