Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tado service set temperature offset #45014

Merged
merged 12 commits into from
Jan 26, 2021
Merged

Add tado service set temperature offset #45014

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
72da0bd
Add ability to set temprature offset and corresponding service
north3221 Jan 10, 2021
bc3f27e
Used black to fix formatting issues
north3221 Jan 10, 2021
01b2129
Fixed trailing spaces in yaml
north3221 Jan 10, 2021
1929659
Fixed comment formatting for flake
north3221 Jan 10, 2021
fb4c2ee
Changed log level to debug for temp offset change
north3221 Jan 11, 2021
c62f90b
Added temp offset as an atrribute so can see current value
north3221 Jan 11, 2021
7a73341
Added constants for temp offset and updated test
north3221 Jan 11, 2021
6125c25
fixed isort and json format for mock
north3221 Jan 11, 2021
c8f2f6f
Added offset mock for WR4
north3221 Jan 11, 2021
398305b
Added check to ensure key exists before assigning offset
north3221 Jan 11, 2021
b54baf7
Added check to ensure key and device_id exists before assigning offset
north3221 Jan 11, 2021
af1a6d9
Incorporated commets removing _update_offset()
north3221 Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions homeassistant/components/tado/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,13 @@ def update_sensor(self, sensor_type, sensor):
try:
if sensor_type == "device":
data = self.tado.getDeviceInfo(sensor)
if (
"INSIDE_TEMPERATURE_MEASUREMENT"
in data["characteristics"]["capabilities"]
):
data["TEMP_OFFSET"] = self.tado.getDeviceInfo(
sensor, "temperatureOffset"
)
elif sensor_type == "zone":
data = self.tado.getZoneState(sensor)
else:
Expand Down
15 changes: 15 additions & 0 deletions homeassistant/components/tado/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ def __init__(

self._tado_zone_data = None

self._tado_zone_temp_offset = dict()
MartinHjelmare marked this conversation as resolved.
Show resolved Hide resolved

self._async_update_zone_data()

async def async_added_to_hass(self):
Expand Down Expand Up @@ -457,6 +459,11 @@ def swing_modes(self):
return [TADO_SWING_ON, TADO_SWING_OFF]
return None

@property
def device_state_attributes(self):
"""Return temperature offset."""
return self._tado_zone_temp_offset

def set_swing_mode(self, swing_mode):
"""Set swing modes for the device."""
self._control_hvac(swing_mode=swing_mode)
Expand All @@ -465,11 +472,19 @@ def set_swing_mode(self, swing_mode):
def _async_update_zone_data(self):
"""Load tado data into zone."""
self._tado_zone_data = self._tado.data["zone"][self.zone_id]
self._update_offset()
self._current_tado_fan_speed = self._tado_zone_data.current_fan_speed
self._current_tado_hvac_mode = self._tado_zone_data.current_hvac_mode
self._current_tado_hvac_action = self._tado_zone_data.current_hvac_action
self._current_tado_swing_mode = self._tado_zone_data.current_swing_mode

def _update_offset(self):
MartinHjelmare marked this conversation as resolved.
Show resolved Hide resolved
# Add 'offset' to the key so its named correctly as an attribute in HA
for key in self._tado.data["device"][self._device_id]["TEMP_OFFSET"]:
self._tado_zone_temp_offset["offset_" + key] = self._tado.data["device"][
MartinHjelmare marked this conversation as resolved.
Show resolved Hide resolved
self._device_id
]["TEMP_OFFSET"][key]

@callback
def _async_update_callback(self):
"""Load tado data and update state."""
Expand Down