Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qbittorent config flow #45586

Conversation

geoffreylagaisse
Copy link
Contributor

Proposed change

Upgrade the qbittorrent component to flow, and used the internal async processes of hass.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

geoffreylagaisse and others added 30 commits July 17, 2020 11:35
Merge Hassiochanges in fork
Merge Home-assistant in dev
Added the suggestions of ktnrg45

Co-authored-by: ktnrg45 <38207570+ktnrg45@users.noreply.github.com>
Added the suggestions of ktnrg45

Co-authored-by: ktnrg45 <38207570+ktnrg45@users.noreply.github.com>
Added the suggestions of ktnrg45

Co-authored-by: ktnrg45 <38207570+ktnrg45@users.noreply.github.com>
@project-bot project-bot bot added this to Needs review in Dev Jan 26, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 26, 2021
@geoffreylagaisse geoffreylagaisse mentioned this pull request Jan 26, 2021
21 tasks
@ktnrg45
Copy link
Contributor

ktnrg45 commented Jan 26, 2021

Hi. There are still some unrelated commits in this PR.

You shouldn't have to merge after rebasing. Simply do a force push instead.

@geoffreylagaisse
Copy link
Contributor Author

ah yes I see, there are double commits, but they are all mine and the end result is the same.
I will keep it in mind for my next PR. I'm used to do merges on the projects I work on professionally, sorry :-S

@dgomes
Copy link
Contributor

dgomes commented Jan 27, 2021

you better rebase...

Also don't need to commit translation files (they will be generated afterwards)

@ktnrg45
Copy link
Contributor

ktnrg45 commented Jan 27, 2021

I'm sure all of us have done this at some point. Dealing with an upstream repo adds some complexity.

Sorry I meant to say that if you look in files changed there are files there which are unrelated (alexa for example). IMO probably not the best way but you could probably do the following on your PR branch to correct this.

git reset --hard HEAD~1

Check git log to make sure that the latest commit is the one before your last merge commit.

If everything looks good rebase with upstream then force push.

@geoffreylagaisse
Copy link
Contributor Author

geoffreylagaisse commented Jan 27, 2021

I'm sure all of us have done this at some point. Dealing with an upstream repo adds some complexity.

Sorry I meant to say that if you look in files changed there are files there which are unrelated (alexa for example). IMO probably not the best way but you could probably do the following on your PR branch to correct this.

git reset --hard HEAD~1

Check git log to make sure that the latest commit is the one before your last merge commit.

If everything looks good rebase with upstream then force push.

Didn't work. I had to create a new branch that was up to date with upstream and I merged the changes of the messed up one in it
I hope this one fixes it ... #45618

Dev automation moved this from By Code Owner to Cancelled Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

4 participants