-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qbittorent config flow #45586
Add Qbittorent config flow #45586
Conversation
Merge Hassiochanges in fork
Merge Home-assistant in dev
Merge Hass Dev
…eature/qbittorrentconfigflow
Added the suggestions of ktnrg45 Co-authored-by: ktnrg45 <38207570+ktnrg45@users.noreply.github.com>
Added the suggestions of ktnrg45 Co-authored-by: ktnrg45 <38207570+ktnrg45@users.noreply.github.com>
…offreylagaisse/core into feature/qbittorrentconfigflow
Added the suggestions of ktnrg45 Co-authored-by: ktnrg45 <38207570+ktnrg45@users.noreply.github.com>
Hi. There are still some unrelated commits in this PR. You shouldn't have to merge after rebasing. Simply do a force push instead. |
ah yes I see, there are double commits, but they are all mine and the end result is the same. |
you better rebase... Also don't need to commit translation files (they will be generated afterwards) |
I'm sure all of us have done this at some point. Dealing with an upstream repo adds some complexity. Sorry I meant to say that if you look in files changed there are files there which are unrelated (alexa for example). IMO probably not the best way but you could probably do the following on your PR branch to correct this.
Check git log to make sure that the latest commit is the one before your last merge commit. If everything looks good rebase with upstream then force push. |
Didn't work. I had to create a new branch that was up to date with upstream and I merged the changes of the messed up one in it |
Proposed change
Upgrade the qbittorrent component to flow, and used the internal async processes of hass.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: