New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Hyperion human-readable effect names instead of API identifiers #45763
Use Hyperion human-readable effect names instead of API identifiers #45763
Conversation
14c8034
to
31ec430
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
This PR is still live, still desired and I'm still happy to respond to any feedback if someone has time to review. Thank you. |
faa3c11
to
6c159ee
Compare
6c159ee
to
27ab615
Compare
[April update, rebased from dev] This PR is still live, still desired and I'm still happy to respond to any feedback if someone has time to review. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dermotduffy 馃憤
../Frenck 馃殏
Thank you! |
Proposed change
Hyperion itself uses one set of identifiers in its API to refer to components/"sources" (e.g. "GRABBER", "V4L"), but its UI uses a different set of friendlier names (e.g. "Platform Capture", "USB Capture"). The home assistant integration currently uses the "unfriendly" API identifier in the light component, but the friendly UI names in the switch component.
This change deprecates these API identifiers (they won't be shown in the list, but automations that use them will still work and will print a warning).
Once this change is submitted, the switch component, light component and the Hyperion UI will all be using the same names.
Underlying library changes: dermotduffy/hyperion-py@v0.7.0...v0.7.2
Home Assistant Hyperion component:
Hyperion-UI (remote panel):
Type of change
Example entry for
configuration.yaml
:None.
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: