Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyatv to 0.7.6 #45799

Merged
merged 1 commit into from Feb 1, 2021
Merged

Bump pyatv to 0.7.6 #45799

merged 1 commit into from Feb 1, 2021

Conversation

postlund
Copy link
Contributor

@postlund postlund commented Jan 31, 2021

Proposed change

Upgrade pyatv to 0.7.6 with the following changes (extract from change log):

  • DNS parsing has been re-written which should be more stable and handle more use cases
  • TCP keep-alive has been added to more platforms, FreeBSD being one of them
  • Player management has been totally re-written for MRP, so hopefully play state should be more accurate now
  • A delay has been added to turn_off (MRP), so it should work again
  • A heartbeat loop has been added that sends a "heartbeat" to the device every 30s to detect connection problems
  • Protobuf definitions have been further lifted to match later tvOS version
  • Fixed a bug where Playing instancess were not immutable
  • Push updates are only issued when something in the Playing instance changed. Previously, unrelated changes to the device could trigger push updates with the same content in Playing.

https://github.com/postlund/pyatv/releases/tag/v0.7.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jan 31, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 31, 2021
@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@MartinHjelmare
Copy link
Member

I've added the link. 👍

@postlund
Copy link
Contributor Author

You beat me to it! 🚴‍♂️

Dev automation moved this from By Code Owner to Reviewer approved Jan 31, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@postlund
Copy link
Contributor Author

If it's possible to wish, it would be great to have this included in the next release as it fixes a few issues people are having.

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Jan 31, 2021

And the other changes are safe, ie don't mean users need to change anything?

@postlund
Copy link
Contributor Author

Nah, it's just bug fixes and robustness enhancements in this release.

@MartinHjelmare MartinHjelmare added this to the 2021.2.0 milestone Jan 31, 2021
@MartinHjelmare
Copy link
Member

Ok, tagged. 👍

@bdraco
Copy link
Member

bdraco commented Feb 1, 2021

Just tested and everything appears to be working as expected.

I did notice that the mdns processing (https://www.home-assistant.io/integrations/profiler/) is the most expensive operation on an idle instance:

Screen Shot 2021-01-31 at 9 19 29 PM

@MartinHjelmare MartinHjelmare merged commit 03928db into home-assistant:dev Feb 1, 2021
Dev automation moved this from Reviewer approved to Done Feb 1, 2021
@postlund
Copy link
Contributor Author

postlund commented Feb 1, 2021

@bdraco Great catch, can you open an issue in the pyatv project and include the image?

c0fec0de pushed a commit to c0fec0de/home-assistant that referenced this pull request Feb 1, 2021
balloob pushed a commit that referenced this pull request Feb 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants