New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target to service call API #45898
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
homeassistant/core.py
Outdated
@@ -1418,6 +1422,9 @@ async def async_call( | |||
else: | |||
processed_data = service_data | |||
|
|||
if target: | |||
processed_data.update(target) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be like this or should it split out in service call too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we check the schema it needs to be in the data, or all schemas need updating...
Proposed change
Allow a target to be passed to a service call, like we already supported for scripts
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: