Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Plaato post merge review #46024

Merged

Conversation

JohNan
Copy link
Contributor

@JohNan JohNan commented Feb 5, 2021

Proposed change

Post merge review fixes pointed out by reviewer

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Feb 5, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 5, 2021
@JohNan JohNan changed the title Post merge review fixes Plaato Post merge review fixes Feb 5, 2021
@JohNan JohNan changed the title Plaato Post merge review fixes Plaato: Post merge review fixes Feb 5, 2021
@MartinHjelmare MartinHjelmare changed the title Plaato: Post merge review fixes Address Plaato post merge review Feb 5, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Dev automation moved this from By Code Owner to Reviewer approved Feb 5, 2021
@MartinHjelmare MartinHjelmare merged commit 55f81a8 into home-assistant:dev Feb 5, 2021
Dev automation moved this from Reviewer approved to Done Feb 5, 2021
@JohNan JohNan deleted the plaato-post-merge-review-fixes branch February 5, 2021 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants