-
-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix climate hold bug in ecobee #46613
Conversation
Return None instead of 0 since 0 is not a valid API value and we can more easily deal with None down the line in API calls.
Always pass hold_hours to the API call; if the parameter is not required, the API will filter it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this includes a dependency bump, please post a link to the changelog or diff in the opening text
@bdraco Diff for the dependency added. Since this is a bug fix is possible to get this into a point release? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
This PR fixes a bug that was introduced in #40520 and which has been raised as an issue in #45936. As a result of the changes in #40520, we need to pass the holdHours parameter to the ecobee API when relevant. This PR ensures that the user's holdHours preference is always passed to the ecobee API call. The dependency bump of python-ecobee-api is required to implement support for filtering this parameter out of the API call when it is not relevant.
Dependency diff: nkgilley/python-ecobee-api@0.2.9...0.2.10
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: