Fix climate hold bug in ecobee #46613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return None instead of 0 since 0 is not a valid API value and we can more easily deal with None down the line in API calls.
Always pass hold_hours to the API call; if the parameter is not required, the API will filter it out.
probot-home-assistant
bot
added
bugfix
dependency
integration: ecobee
small-pr
bdraco
requested changes
Feb 16, 2021
|
@bdraco Diff for the dependency added. Since this is a bug fix is possible to get this into a point release? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR fixes a bug that was introduced in #40520 and which has been raised as an issue in #45936. As a result of the changes in #40520, we need to pass the holdHours parameter to the ecobee API when relevant. This PR ensures that the user's holdHours preference is always passed to the ecobee API call. The dependency bump of python-ecobee-api is required to implement support for filtering this parameter out of the API call when it is not relevant.
Dependency diff: nkgilley/python-ecobee-api@0.2.9...0.2.10
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: