Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Mitemp_bt constants #46881

Merged
merged 3 commits into from Feb 22, 2021
Merged

Clean up Mitemp_bt constants #46881

merged 3 commits into from Feb 22, 2021

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented Feb 21, 2021

Breaking change

Proposed change

Clean up Mitemp_bt.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Feb 21, 2021
Dev automation moved this from Needs review to Reviewer approved Feb 22, 2021
Copy link
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to rebase/remove the commit for acer_projector in the PR 馃檪

@cgarwood cgarwood changed the title Clean up Mitemp_bt Clean up Mitemp_bt constants Feb 22, 2021
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unrelated commit in this PR. Please git rebase to clean it up.

Dev automation moved this from Reviewer approved to Review in progress Feb 22, 2021
@cgtobi
Copy link
Contributor

cgtobi commented Feb 22, 2021

@frenck that acer_projector 锟糲hange? I guessed it was part of his whole effort to clean up constants.

@frenck
Copy link
Member

frenck commented Feb 22, 2021

@cgtobi That commit was part of #46880 and leaked into this branch.

@cgtobi
Copy link
Contributor

cgtobi commented Feb 22, 2021

Ah, well spotted. I didn't cross check that. 馃憤

@cgtobi cgtobi merged commit f0c7aff into home-assistant:dev Feb 22, 2021
Dev automation moved this from Review in progress to Done Feb 22, 2021
@tkdrob tkdrob deleted the mitemp_bt branch February 22, 2021 20:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants