New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-garminconnect to 0.1.19 to fix broken api #47020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@frenck sorry to ping you, but can this be released in production asap? It fixes a broken Garmin integration (as of 23rd of Feb) due to a change in the Garmin API. Thanks! |
@cyberjunky In your PR there is only a single commit linked. Furthermore, I cannot see the release or the changes between the bump done in this PR: https://github.com/cyberjunky/python-garminconnect/releases Is missing releases as well. Could you provide a git compare link? Or even better, mark releases? |
@frenck thanks, I created the missing 0.1.18 release. This is the complete git compare from 0.1.16 to 0.1.19 Code changes between 0.1.16 and 0.1.18 are only related to added functionality (new API calls) but these are not used by the Garmin Connect integration code. There are quite a few people using the python-garminconnect for other/their own projects. |
@frenck sorry, my mistake. Should have noticed that. Changes seemed reasonable though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @cyberjunky Thanks!
I'm tagging it for the next beta, the next first available stable channel release is 2021.3.0 upcoming Wednesday.
Breaking change
Proposed change
This PR bumps python-garminconnect to version 0.1.19 to fix a broken api, garmin changed an url yesterday which broke the integration. (Resulted in error 402 errors)
Changes in dependency
cyberjunky/python-garminconnect@daba147
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: