Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-garminconnect to 0.1.19 to fix broken api #47020

Merged
merged 1 commit into from Feb 25, 2021
Merged

Bump python-garminconnect to 0.1.19 to fix broken api #47020

merged 1 commit into from Feb 25, 2021

Conversation

cyberjunky
Copy link
Contributor

Breaking change

Proposed change

This PR bumps python-garminconnect to version 0.1.19 to fix a broken api, garmin changed an url yesterday which broke the integration. (Resulted in error 402 errors)

Changes in dependency
cyberjunky/python-garminconnect@daba147

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Feb 24, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 24, 2021
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from By Code Owner to Reviewer approved Feb 25, 2021
@cyberjunky
Copy link
Contributor Author

@frenck sorry to ping you, but can this be released in production asap? It fixes a broken Garmin integration (as of 23rd of Feb) due to a change in the Garmin API. Thanks!

@frenck
Copy link
Member

frenck commented Feb 25, 2021

@cyberjunky In your PR there is only a single commit linked. Furthermore, I cannot see the release or the changes between the bump done in this PR:

https://github.com/cyberjunky/python-garminconnect/releases

Is missing releases as well. Could you provide a git compare link? Or even better, mark releases?

@cyberjunky
Copy link
Contributor Author

@frenck thanks, I created the missing 0.1.18 release.

This is the complete git compare from 0.1.16 to 0.1.19
cyberjunky/python-garminconnect@0.1.16...0.1.19

Code changes between 0.1.16 and 0.1.18 are only related to added functionality (new API calls) but these are not used by the Garmin Connect integration code. There are quite a few people using the python-garminconnect for other/their own projects.

@cgtobi
Copy link
Contributor

cgtobi commented Feb 25, 2021

@frenck sorry, my mistake. Should have noticed that. Changes seemed reasonable though.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @cyberjunky Thanks!

I'm tagging it for the next beta, the next first available stable channel release is 2021.3.0 upcoming Wednesday.

@frenck frenck added this to the 2021.3.0 milestone Feb 25, 2021
@frenck frenck merged commit 3a82917 into home-assistant:dev Feb 25, 2021
Dev automation moved this from Reviewer approved to Done Feb 25, 2021
@cyberjunky cyberjunky deleted the garmin-bump-0.1.19 branch February 25, 2021 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Didn't receive data from Garmin Connect
5 participants