Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Z-Wave JS API docstrings #47061

Merged
merged 1 commit into from Feb 26, 2021
Merged

Fix Z-Wave JS API docstrings #47061

merged 1 commit into from Feb 26, 2021

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Feb 25, 2021 •
edited

Proposed change

Correct the docstring for websocket_get_log_config() and fix a typo in websocket_get_config_parameters()

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

@project-bot project-bot bot added this to Needs review in Dev Feb 25, 2021
milanmeu
milanmeu approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@milanmeu milanmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MartinHjelmare
Copy link
Member

I don't see the type fix.

@cgarwood
Copy link
Member Author

Oops, should have been typo instead of type. Do I win a prize for typo'ing typo?

raman325
raman325 approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching that

Dev automation moved this from Needs review to Reviewer approved Feb 26, 2021
@balloob balloob merged commit 8ab163e into home-assistant:dev Feb 26, 2021
Dev automation moved this from Reviewer approved to Done Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2021
@cgarwood cgarwood deleted the zwjs_api_comments branch November 2, 2023 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@raman325 raman325 raman325 approved these changes

@milanmeu milanmeu milanmeu approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality integration: zwave_js small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cgarwood @MartinHjelmare @raman325 @milanmeu @balloob @homeassistant