Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RFLink TCP KeepAlive error log #47395

Merged
merged 1 commit into from Mar 5, 2021
Merged

Fix RFLink TCP KeepAlive error log #47395

merged 1 commit into from Mar 5, 2021

Conversation

cpainchaud
Copy link
Contributor

Proposed change

Fix for RFLink component which spits an error message when using serial
based device where it would try to activate TCP KeepAlive because of a
missing check (host = None means this is a serial connection)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 4, 2021
@probot-home-assistant
Copy link

Hey there @javicalle, mind taking a look at this pull request as its been labeled with an integration (rflink) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javicalle
Copy link
Contributor

If possible, it should be added to the next fix version

@MartinHjelmare MartinHjelmare changed the title fix RFLink component causing an error messages because of TCP KeepAlive Fix RFLink TCP KeepAlive error log Mar 5, 2021
Dev automation moved this from Needs review to Reviewer approved Mar 5, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2021.3.1 milestone Mar 5, 2021
@MartinHjelmare MartinHjelmare merged commit a1faba2 into home-assistant:dev Mar 5, 2021
Dev automation moved this from Reviewer approved to Done Mar 5, 2021
balloob pushed a commit that referenced this pull request Mar 5, 2021
@balloob balloob mentioned this pull request Mar 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

rflink throws an error on startup
5 participants