Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Eight Sleep to config flow and fix minor issues #47493

Closed
wants to merge 1 commit into from

Conversation

robbiet480
Copy link
Member

@robbiet480 robbiet480 commented Mar 6, 2021

Proposed change

Converts Eight Sleep to use config flow and fixes minor issues

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @mezz64, mind taking a look at this pull request as its been labeled with an integration (eight_sleep) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@github-actions
Copy link

github-actions bot commented Apr 5, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 5, 2021
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Apr 9, 2021
@github-actions github-actions bot closed this Apr 12, 2021
Dev automation moved this from Incoming to Cancelled Apr 12, 2021
@frenck frenck reopened this Apr 12, 2021
Dev automation moved this from Cancelled to Incoming Apr 12, 2021
@frenck
Copy link
Member

frenck commented Apr 12, 2021

@robbiet480 This one closed without review, but it didn't pass builds either. Could you rebase this on the latest dev? I think it might pass after that.

@MartinHjelmare
Copy link
Member

It's draft. Is it ready for review?

@github-actions github-actions bot removed the stale label Apr 12, 2021
@frenck
Copy link
Member

frenck commented Apr 12, 2021

Oh I missed that one @MartinHjelmare. It was closed stale as a draft indeed. Closing again.
Feel free to re-open when ready to work on it again @robbiet480 馃憤

@frenck frenck closed this Apr 12, 2021
Dev automation moved this from Incoming to Cancelled Apr 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

4 participants