Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust insteon fan speed range to valid upper bound #47765

Merged
merged 1 commit into from Mar 12, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 11, 2021

Proposed change

We now use the same range as isy994 since setting to 256 is reported to cause a crash.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: insteon small-pr PRs with less than 30 lines. labels Mar 11, 2021
@project-bot project-bot bot added this to Needs review in Dev Mar 11, 2021
@bdraco bdraco added this to the 2021.3.4 milestone Mar 11, 2021
@bdraco bdraco changed the title Adjust insteon speed range to valid upper bound Adjust insteon fan speed range to valid upper bound Mar 11, 2021
@bdraco bdraco marked this pull request as draft March 11, 2021 17:52
@bdraco
Copy link
Member Author

bdraco commented Mar 11, 2021

Had to step away. Will see why CI is failing later today

@bdraco
Copy link
Member Author

bdraco commented Mar 12, 2021

Screen Shot 2021-03-11 at 5 21 12 PM

Tested and working, but in fairness I couldn't replicate the original issue.

@bdraco bdraco marked this pull request as ready for review March 12, 2021 03:23
Dev automation moved this from Needs review to Reviewer approved Mar 12, 2021
@balloob balloob merged commit e2f0b18 into home-assistant:dev Mar 12, 2021
Dev automation moved this from Reviewer approved to Done Mar 12, 2021
@balloob balloob mentioned this pull request Mar 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Fan Integration for Insteon not responding as expected after update to core 2021.3.0
3 participants