Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup in LCN #48074

Merged
merged 3 commits into from May 25, 2021
Merged

Conversation

alengwenus
Copy link
Contributor

@alengwenus alengwenus commented Mar 18, 2021

Proposed change

Code cleanup in LCN.
In particular:

  • two similar helper functions are replaced by a new one
  • a list with all available LCN platforms is added to const.py
  • fixed bug in service call LockKeys caused by a typo
  • fixed typo in services.yaml

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 18, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 18, 2021
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 17, 2021
homeassistant/components/lcn/helpers.py Outdated Show resolved Hide resolved
homeassistant/components/lcn/helpers.py Outdated Show resolved Hide resolved
homeassistant/components/lcn/helpers.py Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Review in progress Apr 18, 2021
@alengwenus alengwenus requested a review from frenck April 21, 2021 12:55
@alengwenus alengwenus force-pushed the dev-lcn-code-cleanup branch 3 times, most recently from 16786e4 to 70a8813 Compare May 16, 2021 10:02
Dev automation moved this from Review in progress to Reviewer approved May 25, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @alengwenus 馃憤

../Frenck

@frenck frenck merged commit c868353 into home-assistant:dev May 25, 2021
Dev automation moved this from Reviewer approved to Done May 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
@alengwenus alengwenus deleted the dev-lcn-code-cleanup branch October 30, 2021 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants