New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanup in LCN #48074
Merged
Merged
Code cleanup in LCN #48074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
integration: lcn
small-pr
PRs with less than 30 lines.
by-code-owner
labels
Mar 18, 2021
alengwenus
force-pushed
the
dev-lcn-code-cleanup
branch
from
March 18, 2021 11:53
48082b5
to
672d726
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
frenck
requested changes
Apr 18, 2021
alengwenus
force-pushed
the
dev-lcn-code-cleanup
branch
from
April 18, 2021 11:55
83f07cf
to
84d16a2
Compare
alengwenus
force-pushed
the
dev-lcn-code-cleanup
branch
3 times, most recently
from
May 16, 2021 10:02
16786e4
to
70a8813
Compare
alengwenus
force-pushed
the
dev-lcn-code-cleanup
branch
from
May 16, 2021 11:53
70a8813
to
f8a3495
Compare
frenck
reviewed
May 17, 2021
alengwenus
force-pushed
the
dev-lcn-code-cleanup
branch
from
May 22, 2021 13:31
ff676d5
to
a5d02fb
Compare
frenck
approved these changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @alengwenus 馃憤
../Frenck
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Code cleanup in LCN.
In particular:
const.py
LockKeys
caused by a typoservices.yaml
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: