Ensure homekit yaml config works when there is an ignored config entry #48175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: homekit
small-pr
bdraco
commented
Mar 21, 2021
| @@ -222,7 +222,7 @@ def _async_current_names(self): | |||
| return { | |||
| entry.data[CONF_NAME] | |||
| for entry in self._async_current_entries() | |||
There was a problem hiding this comment.
Async current entries ignores the arg to skip ignored if it's not user flow
There was a problem hiding this comment.
Since that's fixed, I used it directly
21 tasks
bdraco
force-pushed
the
fix_homekit_with_ignored_entry
branch
from
3e61da6
to
edc1102
Compare
balloob
approved these changes
Mar 22, 2021
|
I guess I can use the other one that just merged to make this simplier |
bdraco
force-pushed
the
fix_homekit_with_ignored_entry
branch
from
edc1102
to
be0bac8
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Ensure homekit yaml config works when there is an ignored config entry
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: