Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of nested IF-IF case in elkm1 test #48374

Merged
merged 1 commit into from Mar 26, 2021
Merged

Merge of nested IF-IF case in elkm1 test #48374

merged 1 commit into from Mar 26, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 26, 2021

Proposed change

Small tweak in a elkm1 test that merges a nested IF-IF case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @gwww, @bdraco, mind taking a look at this pull request as its been labeled with an integration (elkm1) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@gwww
Copy link
Contributor

gwww commented Mar 26, 2021

Looks great to me.

Dev automation moved this from Needs review to Reviewer approved Mar 26, 2021
@bdraco bdraco merged commit bbbc3a5 into dev Mar 26, 2021
Dev automation moved this from Reviewer approved to Done Mar 26, 2021
@bdraco bdraco deleted the frenck-2021-0976 branch March 26, 2021 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants