Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional data source to dhcp #48430

Merged
merged 8 commits into from Mar 28, 2021
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 28, 2021

Proposed change

Since many routers provide PTR entries for devices on the local network, we have
enough data to find the hostname, mac, and ip to populate dhcp discovery
data quickly without having to wait. This provides another avenue to get the data
which can allow the devices to be available at onboarding for networks that
provide PTR entries. Additionally this helps close the gap for users who
cannot use scapy due to the root requirement.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 28, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 28, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Mar 28, 2021
@bdraco
Copy link
Member Author

bdraco commented Mar 28, 2021

Thank you!

@bdraco
Copy link
Member Author

bdraco commented Mar 28, 2021

Running one more performance test before merge, but looking good 馃憤

@bdraco
Copy link
Member Author

bdraco commented Mar 28, 2021

Testing looks good.

@bdraco bdraco merged commit 2ff94c8 into home-assistant:dev Mar 28, 2021
Dev automation moved this from Reviewer approved to Done Mar 28, 2021
@bdraco bdraco deleted the dhcp_aiodiscover branch March 28, 2021 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants