Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZHADoorLock locks in deCONZ integration #48516

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Mar 30, 2021

Breaking change

Proposed change

Kane610/deconz@v77...v78

Add support of ZHADoorLock locks which are from the list of sensors rather than lights
Some improvement to the retry logic of the websocket to see if the situation #37372 can be improved

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Mar 30, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 30, 2021
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Mar 31, 2021
@Kane610
Copy link
Member Author

Kane610 commented Mar 31, 2021

Awesome! Thanks @bdraco 馃帀

@Kane610 Kane610 merged commit c80f34a into home-assistant:dev Mar 31, 2021
Dev automation moved this from Reviewer approved to Done Mar 31, 2021
@Kane610 Kane610 deleted the deconz-door_lock_can_originate_from_sensor branch March 31, 2021 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants