Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTS engines in config.components #48939

Merged
merged 5 commits into from Apr 9, 2021
Merged

Add TTS engines in config.components #48939

merged 5 commits into from Apr 9, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Apr 9, 2021

Breaking change

Proposed change

I don't know the backstory here for why these platforms are not registered, but now with the analytics portal that was noticed, and while doing this I also noticed they do not show up in the frontend /config/info.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added core integration: tts small-pr PRs with less than 30 lines. labels Apr 9, 2021
@project-bot project-bot bot added this to Needs review in Dev Apr 9, 2021
@probot-home-assistant
Copy link

Hey there @pvizeli, mind taking a look at this pull request as its been labeled with an integration (tts) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Apr 9, 2021
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an oversight, so yeah should be fixed 馃憤

ludeeus and others added 2 commits April 9, 2021 21:48
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@ludeeus ludeeus marked this pull request as ready for review April 9, 2021 19:53
@balloob balloob added this to the 2021.4.3 milestone Apr 9, 2021
@balloob balloob merged commit eef7faa into dev Apr 9, 2021
Dev automation moved this from Reviewer approved to Done Apr 9, 2021
@balloob balloob deleted the register-tts-engines branch April 9, 2021 23:13
balloob added a commit that referenced this pull request Apr 10, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@balloob balloob mentioned this pull request Apr 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Analytics doesn't report on Google Translate TTS and Microsoft TTS separately from TTS
4 participants