Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internally work with modern config syntax for template binary sensor platform config #48981

Merged
merged 6 commits into from Apr 13, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 10, 2021

Breaking change

Proposed change

This makes the binary sensor internally work with a modern config syntax. This is a requirement to add trigger support.

Aligns config set up with #48976

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@balloob
Copy link
Member Author

balloob commented Apr 12, 2021

If tests fail, they will pass after rebasing on #49094 Rebase done

@balloob balloob force-pushed the template-binary-sensor-modern-syntax branch from b66e42c to af2445e Compare April 12, 2021 05:49
@balloob balloob changed the title Add modern config to template binary sensor Internally work with modern config syntax for template binary sensor platform config Apr 12, 2021
@balloob
Copy link
Member Author

balloob commented Apr 12, 2021

@MartinHjelmare I have also removed the modern config syntax from the platform config here.

Dev automation moved this from Needs review to Reviewer approved Apr 13, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@balloob balloob merged commit beea2dd into dev Apr 13, 2021
Dev automation moved this from Reviewer approved to Done Apr 13, 2021
@balloob balloob deleted the template-binary-sensor-modern-syntax branch April 13, 2021 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants