-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tahoma
integration and move to overkiz
domain
#49403
Conversation
Signed-off-by: Mick Vleeshouwer <mick@imick.nl>
Co-authored-by: J. Nick Koston <nick@koston.org>
tahoma
integration and move to overkiz
domaintahoma
integration and move to overkiz
domain
Why change the name? |
See the discussion in #49165 (comment). TLDR: this integration now support IoT platforms of multiple vendors based on the Overkiz API platform. Not just TaHoma, but also Cozytouch (custom integration now), Hi Kumo (custom integration now) and more. |
Would someone be able to rebase Let's see if we can get this one to core first, and later on add the other platforms directly to |
Any way to move this forward? We are massively out of sync and I am not sure what the best way is for us to move this forward. Have this PR rebased and create new PR's that target this branch, or would another strategy make more sense? Currently 240+ users are using this custom integration (see https://analytics.home-assistant.io/custom_integrations.json) and I believe this would be a lot more with autodiscovery in core. |
Thanks @Quentame! Could you perhaps briefly get in touch with me on Discord (iMick#1903)? I am in favour of updating this PR first, since https://github.com/iMicknl/ha-tahoma had many (good) changes lately. The Overkiz integration as custom component should also offer your Cozytouch devices already. We would love to see this being part of Hacktoberfest, having the Overkiz integration in and the obsolete TaHoma integration removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review WIP
If the Since everything is really out of sync, how about bringing in the component as a new integration in the |
@bdraco you are right. We discussed this a while ago with @Quentame and that seems the best strategy to me.
We have been working on the custom component and are quite in sync with core changes, just the typing is something where we would need to spend more work. However, currently we have some reliability issues that are impacting many users, thus we wait until we figured out a fix with Somfy for that. I will close this PR for now. |
(work in progress, this PR description will be updated every time
rework-tahoma
will be merged)Breaking change
The broken
tahoma
integration will be replaced with the newoverkiz
integration. A user would manually need to create a new config entry for the Overkiz integration via the Config Flow, however they are helped with device discovery via DHCP.MotionSensor
,SmokeSensor
,ContactSensor
mapping from sensor to binary_sensor.GarageDoor
mapping from switch to cover.OnOffLight
from switch to lightassumed_state = True
.Proposed change
General
Cover
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: