Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play_media channel support to LG Netcast #49527

Merged
merged 2 commits into from May 20, 2021
Merged

Add play_media channel support to LG Netcast #49527

merged 2 commits into from May 20, 2021

Conversation

Drafteed
Copy link
Contributor

@Drafteed Drafteed commented Apr 21, 2021

Proposed change

Add support media_player.play_media service for LG Netcast. Currently only supports channels. Allows users to specify specific digital tuner channel for their tv to display. Also media_content_id now contains current channel number.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: #17543

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@Drafteed
Copy link
Contributor Author

@MartinHjelmare can you take a look?

homeassistant/components/lg_netcast/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/lg_netcast/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/lg_netcast/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/lg_netcast/media_player.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress May 20, 2021
@Drafteed
Copy link
Contributor Author

@MartinHjelmare done!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from Review in progress to Reviewer approved May 20, 2021
@MartinHjelmare MartinHjelmare merged commit f3db819 into home-assistant:dev May 20, 2021
Dev automation moved this from Reviewer approved to Done May 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants