Add debug more information when splitting entity ID failed

[frenck]

Proposed change

Small change to a core method, that adds more information as soon as an issue occurs with splitting entity ID's.

Issues from 2 reporters during the beta of 2021.5:

Logger: homeassistant.core
Source: core.py:117
First occurred: 18:07:07 (8 occurrences)
Last logged: 21:22:02

Error in event filter
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/core.py", line 717, in async_fire
    if not event_filter(event):
  File "/usr/src/homeassistant/homeassistant/components/recorder/__init__.py", line 367, in _async_event_filter
    return bool(entity_id is None or self.entity_filter(entity_id))
  File "/usr/src/homeassistant/homeassistant/helpers/entityfilter.py", line 169, in entity_filter_2
    domain = split_entity_id(entity_id)[0]
  File "/usr/src/homeassistant/homeassistant/core.py", line 117, in split_entity_id
    return entity_id.split(".", 1)
AttributeError: 'list' object has no attribute 'split'

It would help if we knew the contents that it is trying to split to determine the source of the issue.
This PR adjusts the handling, to raise an HomeAssistant error with the entity_id it actually tries to split.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: AttributeError: 'list' object has no attribute 'split' #49877
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[hmmbob]

Patched it in my running container to see if we can pinpoint the issue before next beta. Thanks Frenck!

[balloob]

Did you expect to include the entity ID in the message? I don't see how the second arg is used?

Also did you verify every place where this is used to make sure no one was catching attribute error?

[hmmbob]

FWIW, it is adding the entity_ids. Patched my running container and got this error after a long wait:

homeassistant.exceptions.HomeAssistantError: ('Unexpected entity ID format', ['switch.grijze_lamp', 'light.window_level', 'switch.staande_lamp', 'switch.zoutlamp', 'climate.woonkamer'])

Full trace in the linked issue.

edit: it's google_assitant, I was able to reproduce. See issue.

[frenck]

Did you expect to include the entity ID in the message?

Yes, see, above. In example linked by @hmmbob

Also did you verify every place where this is used to make sure no one was catching attribute error?

No, but the PR can be closed as the goal of this PR was to find the issue... which has been found. It is caused by this PR:

Send only a single event per incoming Google command
#49449

[balloob]

TIL we can just pass tuples to exceptions 😆