Fix and enable type checks in Rituals Perfume Genie #49947
Conversation
|
Actually there's simpler solution. Just add explicit type annotation for coordinator field: #49898 (comment) coordinator: RitualsDataUpdateCoordinator |
I think I have done that? |
| @@ -24,7 +24,10 @@ class DiffuserEntity(CoordinatorEntity): | |||
| """Representation of a diffuser entity.""" | |||
|
|
|||
| def __init__( | |||
| self, diffuser: Diffuser, coordinator: CoordinatorEntity, entity_suffix: str | |||
| self, | |||
There was a problem hiding this comment.
I can't see it. Should be here.
class DiffuserEntity(CoordinatorEntity):
coordinator: RitualsDataUpdateCoordinatorThere was a problem hiding this comment.
I thought adding an annotation to the function parameter was enough.
I have added the field annotation in 5efca6b.
Why is this only necessary for the custom coordinator and why does mypy not warn about this?
There was a problem hiding this comment.
Why is this only necessary for the custom coordinator
This way mypy can know self.coordinator in entity has type RitualsDataUpdateCoordinator and not DataUpdateCoordinator.
why does mypy not warn about this?
Because you didn't use coordinator._device outside _async_update_data. But if you add more fields there and start using them in entity, mypy won't able to find them. So it's just an extra annotation to let mypy know that self.coordinator is custom entity.
There was a problem hiding this comment.
Looks great to me, thank you for fixing this! You need to rebase to fix conflict in mypy.ini.
@MartinHjelmare please take a look.
milanmeu
force-pushed
the
fix-typing-rituals
branch
from
5efca6b
to
bfd2c67
Compare
|
Needs rebase again following merge of #50030 |
milanmeu
force-pushed
the
fix-typing-rituals
branch
from
bfd2c67
to
87cd8e0
Compare
homeassistant/components/rituals_perfume_genie/binary_sensor.py
Outdated
Show resolved
Hide resolved
Proposed change
RitualsPerfumeGenieDataUpdateCoordinator->RitualsDataUpdateCoordinatorI will add more typing and enable strict typing after this PR has merged.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: