Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core Sonos functionality out of entities #50277

Merged
merged 7 commits into from May 11, 2021

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented May 8, 2021

Proposed change

Followup from #49441 to move more core Sonos functionality out of the entities:

  • Avoid storing media_player references
  • Move event handlers to SonosSpeaker, avoid dispatch overload
  • Move speaker group handling to SonosSpeaker
  • Streamline entity models

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Move grouping methods to speaker
Move coordinator handling to speaker
Remove unnecessary dispatchers
Remove media_player_entities store
Create class for current media
@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev May 8, 2021
@jjlawren jjlawren marked this pull request as ready for review May 8, 2021 21:47
Dev automation moved this from By Code Owner to Reviewer approved May 11, 2021
@balloob balloob merged commit d6a202b into home-assistant:dev May 11, 2021
Dev automation moved this from Reviewer approved to Done May 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2021
@jjlawren jjlawren deleted the sonos_move_to_speaker branch May 31, 2022 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants