New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smhi wind gust speed and thunder probability #50328
Merged
MartinHjelmare
merged 8 commits into
home-assistant:dev
from
crallian:smhi_extra_attributes
May 10, 2021
Merged
Add smhi wind gust speed and thunder probability #50328
MartinHjelmare
merged 8 commits into
home-assistant:dev
from
crallian:smhi_extra_attributes
May 10, 2021
Commits on May 9, 2021
-
Added the extra attributes wind_gust_speed and thunder_probability that were already implemented in the underlaying library (joysoftware / pypi_smhi). Also for the existing extra attribute cloudiness, it is added if "is not None" instead of just "if self.cloudiness" which would make it False (and therefore not available) if cloudiness = 0.
Configuration menu - View commit details
-
Copy full SHA for 0bf38e4 - Browse repository at this point
Copy the full SHA 0bf38e4View commit details -
Trying to solve the style issues
Removed white spaces and changed order of list as suggested by the tests.
Configuration menu - View commit details
-
Copy full SHA for eafb0f6 - Browse repository at this point
Copy the full SHA eafb0f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0dc8ef - Browse repository at this point
Copy the full SHA f0dc8efView commit details -
Changed dictionary handling as suggested
Changed dictionary handling as suggested by MartinHjelmare.
Configuration menu - View commit details
-
Copy full SHA for 1aea520 - Browse repository at this point
Copy the full SHA 1aea520View commit details
Commits on May 10, 2021
-
Updated test_weather.py to include the new attributes wind_gust_speed and thunder_probability.
Configuration menu - View commit details
-
Copy full SHA for 2b3342b - Browse repository at this point
Copy the full SHA 2b3342bView commit details -
Added the missing imports ATTR_SMHI_THUNDER_PROBABILITY, ATTR_SMHI_WIND_GUST_SPEED,
Configuration menu - View commit details
-
Copy full SHA for 0489673 - Browse repository at this point
Copy the full SHA 0489673View commit details -
Renaming self.thunder to self.thunder_probability and correcting test…
… valuesfor Renamed the new internal attribute thunder to thunder_probability, same as the exposed attribute for improved consistency. Corrected test values according to smhi.json.
Configuration menu - View commit details
-
Copy full SHA for ce6362f - Browse repository at this point
Copy the full SHA ce6362fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be7020 - Browse repository at this point
Copy the full SHA 3be7020View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.