Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AVM FRITZ!Box Tools device_tracker entities by default #50791

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented May 17, 2021

Breaking change

Since in most cases the amount of really wanted to be tracked devices is quite lower than the overall count of devices, device_tracker entities will be disabled by default and the user needs to enable wanted device_trackers, even newly detected devices.

Proposed change

After discussions starting from #50574 (comment) device_trackers from platform fritz will be disabled by default, since in most cases the amount of really wanted to be tracked devices is quite lower than the overall count of devices.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @mammuth, @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as its been labeled with an integration (fritz) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@tschamm tschamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me and shows the expected behavior during initialization.

I wonder if disable_new_entities property should be added as well? To my understanding new entities of the same config entry are otherwise added by default.

@mib1185
Copy link
Contributor Author

mib1185 commented May 18, 2021

I would keep disable_new_entities as is, since new device_tracker entities will still be added, but still disabled based on entity_registry_enabled_default

Copy link
Contributor

@tschamm tschamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your explanation. Ok from my side.

@tschamm
Copy link
Contributor

tschamm commented May 18, 2021

Why is this a breaking change? Your changes will only affect entities which are newly registered. Users who already loaded the integration will not see a changed behavior.

@mib1185
Copy link
Contributor Author

mib1185 commented May 18, 2021

Yeah, honestly I struggled a bit with my self, if it is a breaking change or not, but in case a new devices is detected by Fritzbox, currently it will be added as enabled device_tracker , after this PR it will be still added, but disabled.

EDIT: I've extended the breaking change note, to make it more clear

@janiversen
Copy link
Member

When an integration changes behavior it is good to state it as a breaking change, even though many will no5 be affected.

The edit made it more understandable

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved May 18, 2021
@MartinHjelmare MartinHjelmare changed the title Disable device_tracker by default on AVM FRITZ!Box Tools Disable AVM FRITZ!Box Tools device_tracker entities by default May 18, 2021
@MartinHjelmare MartinHjelmare merged commit 2cd2e46 into home-assistant:dev May 18, 2021
Dev automation moved this from Reviewer approved to Done May 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2021
@mib1185 mib1185 deleted the fritz-device_tracker_default_disbaled branch November 1, 2021 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants