New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable AVM FRITZ!Box Tools device_tracker entities by default #50791
Disable AVM FRITZ!Box Tools device_tracker entities by default #50791
Conversation
Hey there @mammuth, @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as its been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me and shows the expected behavior during initialization.
I wonder if disable_new_entities
property should be added as well? To my understanding new entities of the same config entry are otherwise added by default.
I would keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your explanation. Ok from my side.
Why is this a breaking change? Your changes will only affect entities which are newly registered. Users who already loaded the integration will not see a changed behavior. |
Yeah, honestly I struggled a bit with my self, if it is a breaking change or not, but in case a new devices is detected by Fritzbox, currently it will be added as enabled EDIT: I've extended the breaking change note, to make it more clear |
When an integration changes behavior it is good to state it as a breaking change, even though many will no5 be affected. The edit made it more understandable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Breaking change
Since in most cases the amount of really wanted to be tracked devices is quite lower than the overall count of devices, device_tracker entities will be disabled by default and the user needs to enable wanted device_trackers, even newly detected devices.
Proposed change
After discussions starting from #50574 (comment)
device_trackers
from platformfritz
will be disabled by default, since in most cases the amount of really wanted to be tracked devices is quite lower than the overall count of devices.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: