New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to override insecure setup codes and pair with homekit_controller #50986
Allow user to override insecure setup codes and pair with homekit_controller #50986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we flesh out why we are doing this in the docs? Users might wonder why their device is insecure and if there is anything they can do. We can provide a bit of context about the error, maybe as an FAQ?
Done here home-assistant/home-assistant.io#17937 |
Retested. All looks good 👍 |
Updated the screenshots as well |
Proposed change
Allow user to override insecure setup codes and pair with homekit_controller
User enters insecure setup code
User must re-enter insecure setup code and check the box before they can continue
Note that I tested this using two different instances thus the light and dark mode
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: