Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to override insecure setup codes and pair with homekit_controller #50986

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 23, 2021

Proposed change

Allow user to override insecure setup codes and pair with homekit_controller

User enters insecure setup code
Screen Shot 2021-05-22 at 10 38 43 PM

User must re-enter insecure setup code and check the box before they can continue
Screen Shot 2021-05-23 at 9 14 57 AM

Note that I tested this using two different instances thus the light and dark mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review May 23, 2021 03:40
Dev automation moved this from Needs review to Reviewer approved May 23, 2021
Copy link
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we flesh out why we are doing this in the docs? Users might wonder why their device is insecure and if there is anything they can do. We can provide a bit of context about the error, maybe as an FAQ?

@bdraco bdraco changed the title Allow user to override invalid setup codes and pair with homekit_controller Allow user to override insecure setup codes and pair with homekit_controller May 23, 2021
@bdraco
Copy link
Member Author

bdraco commented May 23, 2021

LGTM. Should we flesh out why we are doing this in the docs? Users might wonder why their device is insecure and if there is anything they can do. We can provide a bit of context about the error, maybe as an FAQ?

Done here home-assistant/home-assistant.io#17937

@bdraco
Copy link
Member Author

bdraco commented May 23, 2021

Retested. All looks good 👍

@bdraco
Copy link
Member Author

bdraco commented May 23, 2021

Updated the screenshots as well

@bdraco bdraco merged commit 4b0b0f5 into home-assistant:dev May 23, 2021
Dev automation moved this from Reviewer approved to Done May 23, 2021
@bdraco bdraco deleted the homekit_controller_handle_invalid_setup_codes branch May 23, 2021 15:15
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

The default device homekit 123-45-678 setting code cannot be added
4 participants