Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pymelcloud 2.5.3 #51043

Merged
merged 1 commit into from May 28, 2021

Conversation

vilppuvuorinen
Copy link
Contributor

@vilppuvuorinen vilppuvuorinen commented May 24, 2021

Previous version of pymelcloud performs requests that are not permitted
for guest users. Bypassing these requests results only in less detailed
device info.

Proposed change

Upgrade pymelcloud to fix issues with guest devices. See vilppuvuorinen/pymelcloud#10 for details. This upgrade backports the fix on top of 2.5.2: https://github.com/vilppuvuorinen/pymelcloud/releases/tag/v2.5.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Previous version of pymelcloud performs requests that are not permitted
for guest users. Bypassing these requests results only in less detailed
device info.
@project-bot project-bot bot added this to Needs review in Dev May 24, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev May 24, 2021
@vilppuvuorinen vilppuvuorinen changed the title WIP: Update to pymelcloud 2.5.3 Update to pymelcloud 2.5.3 May 26, 2021
Copy link

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck added this to the 2021.6.0 milestone May 28, 2021
Dev automation moved this from By Code Owner to Reviewer approved May 28, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vilppuvuorinen 馃憤

@frenck frenck merged commit 99ee2bd into home-assistant:dev May 28, 2021
Dev automation moved this from Reviewer approved to Done May 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants